snark/st
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Unset mode when clearing regions

Browse source 
tclearregion() was clearing regions using spaces and the current
attributes of the terminal. It was correct with all the modes excepct
underline, because they didn't affect the space character, but in
the case of underline it was a problem. A easy way of seeing this
problem is writing this in the last line of the terminal:

	tput smul ; echo first; tput rmul; echo second; echo third

Fist was underlined, and second and third were not underlined, but
the spaces at the right of second was underlined becuause in the
previous scrool underline mode was set.
This commit is contained in:
Roberto E. Vargas Caballero 2014-08-07 10:11:38 +02:00
parent ec3268961d
commit 8de8ae3923
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
st.c
View file

@ -1553,6 +1553,7 @@ tsetchar(char *c, Glyph *attr, int x, int y) {
void void
tclearregion(int x1, int y1, int x2, int y2) { tclearregion(int x1, int y1, int x2, int y2) {
int x, y, temp; int x, y, temp;
Glyph *gp;
if(x1 > x2) if(x1 > x2)
temp = x1, x1 = x2, x2 = temp; temp = x1, x1 = x2, x2 = temp;
@ -1567,10 +1568,13 @@ tclearregion(int x1, int y1, int x2, int y2) {
for(y = y1; y <= y2; y++) { for(y = y1; y <= y2; y++) {
term.dirty[y] = 1; term.dirty[y] = 1;
for(x = x1; x <= x2; x++) { for(x = x1; x <= x2; x++) {
gp = &term.line[y][x];
if(selected(x, y)) if(selected(x, y))
selclear(NULL); selclear(NULL);
term.line[y][x] = term.c.attr; gp->fg = term.c.attr.fg;
memcpy(term.line[y][x].c, " ", 2); gp->bg = term.c.attr.bg;
gp->mode = 0;
memcpy(gp->c, " ", 2);
} }
} }
} }