From 18b02c7f636e4057dcdcceb4887c6d908d4f4d06 Mon Sep 17 00:00:00 2001 From: Richard Schreiber <schreiber@rami.io> Date: Tue, 11 Mar 2025 16:35:04 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Mira <mira@teamwiki.de> --- pretix_servicefees/signals.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pretix_servicefees/signals.py b/pretix_servicefees/signals.py index 032cea7..ee7c3da 100644 --- a/pretix_servicefees/signals.py +++ b/pretix_servicefees/signals.py @@ -153,8 +153,8 @@ def get_fees( d[key] += p.price - p.tax_value trs[key] = tr - base_values = sorted([(trs[t[0]], t[1]) for t in d.items()], key=lambda t: t[0].rate) - sum_base = sum(t[1] for t in base_values) + base_values = sorted([(trs[key], value) for key, value in d.items()], key=lambda t: t[0].rate) + sum_base = sum(value for rule, value in base_values) if sum_base: fee_values = [ (t[0], round_decimal(fee * t[1] / sum_base, event.currency))